Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactcor(dotenv): prepare for noUncheckedIndexedAccess #4261

Merged
merged 5 commits into from
Feb 1, 2024
Merged

refactcor(dotenv): prepare for noUncheckedIndexedAccess #4261

merged 5 commits into from
Feb 1, 2024

Conversation

eryue0220
Copy link
Contributor

This pr is to solve #4040

@eryue0220 eryue0220 requested a review from kt3k as a code owner February 1, 2024 07:47
@github-actions github-actions bot added the dotenv label Feb 1, 2024
@eryue0220 eryue0220 marked this pull request as draft February 1, 2024 07:48
@eryue0220 eryue0220 marked this pull request as ready for review February 1, 2024 07:55
iuioiua
iuioiua reviewed Feb 1, 2024
View reviewed changes
dotenv/parse.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua changed the title refactcor(dotenv): prepare for noUncheckedIndexedAccess refactcor(dotenv): prepare for noUncheckedIndexedAccess Feb 1, 2024
iuioiua
iuioiua approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@iuioiua iuioiua merged commit d8a912f into denoland:main Feb 1, 2024
12 checks passed
@eryue0220 eryue0220 deleted the refactor/dotenv-noUncheckedIndexedAccess branch February 2, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
dotenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eryue0220 @iuioiua